[Feature Anywhere] More bug fixes #4251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu and
manasvinibs
as code owners
ohltyler
requested review from
lezzago
and removed request for
seanneumann,
AMoo-Miki,
kavilla,
zhongnansu,
abbyhu2000,
zengyan-amazon,
ananzh,
kristenTian and
manasvinibs
Signed-off-by: Tyler Ohlsen <[email protected]>
lezzago
approved these changes
Jun 6, 2023
Codecov Report
@@ Coverage Diff @@
## feature/feature-anywhere #4251 +/- ##
=========================================================
Coverage 26.39% 26.39%
=========================================================
Files 150 150
Lines 3554 3554
Branches 407 407
=========================================================
Hits 938 938
Misses 2592 2592
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. |
joshuarrrr
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes 2 bugs:
isEligibleForVisLayers()helper fn, depending on the visualizations passed to it. For example, pie charts don't haveseriesParamsfield, which was leading to the NPE. Adds couple other NPE checks as well, sinceVisParamsunfortunately is very loosely typed so we have to account for lots of potential places where fields may exist in one vis type but not for others.Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr